Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] types requiring imports in alloff, conint, confloat #84

Merged
merged 2 commits into from
Dec 13, 2019

Conversation

krezac
Copy link
Contributor

@krezac krezac commented Dec 12, 2019

Hi Koudai,
thanks for yopur effort on that project, it's useful for us.
Here are couple of fixes I had to implement to be able to process our swagger file.

  • if fields in unnamed object combined with ref in allOf require imports (i.e. string/date), these imports were not included. I'm not sure I've added it the best way, feel free to refactor. AnyOf seems to be fine, I've added couple of cases to tests.
  • pydantic was not included for conint and confloat.

Regards
Kamil

@krezac krezac changed the title [FIX} types requiring imports in alloff, conint, confloat [FIX] types requiring imports in alloff, conint, confloat Dec 12, 2019
@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #84   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         697    701    +4     
  Branches      134    135    +1     
=====================================
+ Hits          697    701    +4
Impacted Files Coverage Δ
...amodel_code_generator/model/pydantic/base_model.py 100% <ø> (ø) ⬆️
datamodel_code_generator/imports.py 100% <100%> (ø) ⬆️
datamodel_code_generator/model/pydantic/types.py 100% <100%> (ø) ⬆️
datamodel_code_generator/parser/openapi.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad35e4c...898496e. Read the comment docs.

@koxudaxi koxudaxi merged commit 2c9e777 into koxudaxi:master Dec 13, 2019
@koxudaxi
Copy link
Owner

koxudaxi commented Dec 13, 2019

@krezac
Thank you for creating this PR.
I did not notice the case :(

It looks good 🎉
I have merged into master, and I have released it as version 0.2.16

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants