Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update from fork #43

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update from fork #43

wants to merge 8 commits into from

Conversation

Bluscream
Copy link

No description provided.

ThanhCN0 and others added 8 commits May 23, 2024 02:21
@ThanhCN0
Replace depreciated constants/functions
e6eddc1
@ThanhCN0
Import entity_registry directly
e2573f3
@ThanhCN0
Use slugify for IDs
326b791 
previous version didn't account for some characters
@ThanhCN0
Fix call from outside event loop
988eab3 
Often called from executor so switched to a threadsafe method
@ThanhCN0
Replace depreciated async_forward_entry_setup
9bfebef 
also fixes a warning for not awaiting
@ThanhCN0
Allow deleting devices from UI
d6fef6f 
useful for removing devices created when the devices openrgb id changes
update authors/repo/deps
11d5c63
add german translation
dbdf34c
Bluscream
Bluscream commented Oct 2, 2024
View reviewed changes
custom_components/openrgb/manifest.json
"issue_tracker": "https://github.com/koying/openrgb_ha/issues",
"requirements": ["openrgb-python==0.2.10"],
"codeowners": ["@bahorn", "@koying"],
"documentation": "https://github.com/Bluscream/openrgb_ha",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to revert these two lines

@felipecrs
Copy link

@koying, this is an easy win. :)

I tested and it's working fine.

@alexayt
Copy link

alexayt commented Oct 4, 2024

I tested as well with OpenRGB 0.9 (Stable) and the integration works fine.
However version 0.9 is anything but stable for me, it is always crashing on my computer. I have resorted to using OpenRGB Pipeline with success.
Unfortunately i cannot make the integration work with Pipeline version. It shows the state of the lights but disconnects upon sending data to server.

OpenRGB log:
[ERROR:] NetworkServer: UpdateLEDs packet has invalid size. Packet size: 26, Data size: 22
[Info:] NetworkServer: Closing server connection: [IP address]

Home Assistant log:
WARNING (SyncWorker_30) [custom_components.openrgb] Connection lost to OpenRGB SDK Server at [IP address]:6742

I am letting you know in case there is a breaking change in current OpenRGB and you want to address it. I apologize if this is the wrong place to do so.

Thanks for keeping the integration alive.

@Bluscream
Copy link
Author

@alexayt have you tried with a OpenRGB (server) nightly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bluscream @felipecrs @alexayt @ThanhCN0