-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threat each newline as separate word in diffWordsWithSpace
#217
Conversation
@kpdecker any feedback? |
… in `diffWordsWithSpace`
810269e
to
9d69baa
Compare
@kpdecker, can we make progress with this? Better late than never |
Sorry for the delay on this, Have very few cycles for this project these days. |
Nice to see that you don't forgot the project |
and there is no best solution. Breaking change is: kpdecker/jsdiff#217
* Bump diff from 4.0.2 to 5.0.0 Bumps [diff](https://github.com/kpdecker/jsdiff) from 4.0.2 to 5.0.0. - [Release notes](https://github.com/kpdecker/jsdiff/releases) - [Changelog](https://github.com/kpdecker/jsdiff/blob/master/release-notes.md) - [Commits](kpdecker/jsdiff@v4.0.2...v5.0.0) Signed-off-by: dependabot[bot] <[email protected]> * fixed tests, the changes to the expected test files' content is minimal and there is no best solution. Breaking change is: kpdecker/jsdiff#217 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tobias Sorn <[email protected]>
IMO the behaviour this produces for
... and here's one with the code after this change:
We're now only sort-of-ignoring whitespace in (In fairness, we were already doing a bad job of ignoring whitespace in |
This fixes #180 & #211