Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle windows newlines on non windows machines. #24

Merged
merged 1 commit into from
Dec 23, 2013

Conversation

benogle
Copy link
Contributor

@benogle benogle commented Dec 12, 2013

value.split(/^/m) splits some\r\ntext into 3 different elements:

['some\r', '\n', 'text']

Not good for diffing! So this makes it:

['some\r\n', 'text']

`value.split(/^/m)` splits the `some\r\ntext` into 3 different elements:

```
['some\r', '\n', 'text']
```

Not good for diffing!
@benogle
Copy link
Contributor Author

benogle commented Dec 12, 2013

Should fix #18 and should fix #20

kpdecker added a commit that referenced this pull request Dec 23, 2013
Handle windows newlines on non windows machines.
@kpdecker kpdecker merged commit df3fc82 into kpdecker:master Dec 23, 2013
@kpdecker
Copy link
Owner

Thanks!

@kpdecker
Copy link
Owner

Released in 1.0.8

This was referenced Dec 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants