Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code coverage reports with added logs and fixed HTML/XML generation #43

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

OlenaYefymenko
Copy link
Member

@OlenaYefymenko OlenaYefymenko commented Apr 22, 2024

  • Change condition of generation HTML report for review coverage analysis;
  • Fix double output in the coverage report;
  • Add logs for HTML and XML reports generation and configured fail_under;

Ref #18

@OlenaYefymenko OlenaYefymenko self-assigned this Apr 22, 2024
@OlenaYefymenko OlenaYefymenko added the bug Something isn't working label Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (83166dc) to head (ffa7630).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          118       118           
  Branches         6         6           
=========================================
  Hits           118       118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

manage.py Outdated Show resolved Hide resolved
manage.py Show resolved Hide resolved
manage.py Show resolved Hide resolved
manage.py Show resolved Hide resolved
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
@OlenaYefymenko OlenaYefymenko added the enhancement New feature or request label Apr 22, 2024
@OlenaYefymenko OlenaYefymenko changed the title Correct condition of generation HTML report for review coverage analysis Improve code coverage reports with added logs and updated HTML/XML generation Apr 22, 2024
@OlenaYefymenko OlenaYefymenko changed the title Improve code coverage reports with added logs and updated HTML/XML generation Improve code coverage reports with added logs and fixed HTML/XML generation Apr 22, 2024
@webknjaz
Copy link
Member

@OlenaYefymenko it's better to only use the imperative mood in the PR/commit title lines but not in the long description prose.

@webknjaz
Copy link
Member

Also, the PR title lists many things now while it's best to have exactly one thing that it does mentioned.

@OlenaYefymenko OlenaYefymenko merged commit f6ccd09 into main Apr 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants