Add support for meta tags in locales #84
Open
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed kpumuk#83 creating support for adding meta tags via locales in the format: en: meta_tags: `controller`: `action`: title: My title etc. I have not created any tests as I’m quite frankly not sure how to write them using locales data.
lib/meta_tags/controller_helper.rb
Outdated
| @@ -14,6 +14,7 @@ module ControllerHelper | |||
|
|
|||
| included do | |||
| alias_method_chain :render, :meta_tags | |||
| before_filter: :meta_tags_from_locales | |||
There was a problem hiding this comment.
unexpected token tCOLON
| # [locale].meta_tags.[controller_name].[action].[title|description|keywords] | ||
| # So en.meta_tags.visitors.index.title would be loaded as title for default | ||
| # welcome page in the visitors controller in english. | ||
| def meta_tags_from_locales |
There was a problem hiding this comment.
Assignment Branch Condition size for meta_tags_from_locales is too high. [17.29/15]
so I’ll do that :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #83 creating support for adding meta tags via locales in the
format:
etc.
I have not created any tests as I’m quite frankly not sure how to write
them using locales data.