Add the Pong example to the index page #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krachbumm3nte
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
This looks great on the website. Regarding the rendering of the GIF files: Since I will have to change the backend of the Pong example from PIL to matplotlib aswell, do I have to add padding to the images too, or is this rather about the final image size of 400x300px?
The gifs have padding so not be stretched awkwardly in the card, but for for adapting to matplotlib, I dont think you have to worry about changing the output in any way. |
krachbumm3nte
pushed a commit
that referenced
this pull request
Oct 26, 2022
Converted test to modern pytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the example files into the index grid, along with modified image to scale properly. The gif was moved from pynest/examples to the docs/htmldoc/static/img folder. Do not want to duplicate as it's fairly large but it needs to be accessible for the docs. Also scaled the sudoku gif so it renders better.
See example output here: https://nest-test.readthedocs.io/en/add-pong-index/examples/index.html#pynest-examples