Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang: Upgrade to 19.x release #982

Merged
merged 10 commits into from
Sep 18, 2024
Merged

clang: Upgrade to 19.x release #982

merged 10 commits into from
Sep 18, 2024

Conversation

kraj
Copy link
Owner

@kraj kraj commented Jul 25, 2024 •
edited
Loading

Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@kraj kraj force-pushed the kraj/clang-19 branch 3 times, most recently from 56cf8ea to afedde8 Compare July 30, 2024 18:52
@kraj kraj force-pushed the kraj/clang-19 branch 3 times, most recently from cabe4f2 to 3e63668 Compare August 11, 2024 15:56
@kraj kraj force-pushed the kraj/clang-19 branch 4 times, most recently from 515b3c3 to b994e44 Compare August 22, 2024 05:57
shr-project
shr-project reviewed Aug 30, 2024
View reviewed changes
dynamic-layers/openembedded-layer/recipes-devtools/bpftrace/bpftrace_0.21.2.bb Outdated
file://run-ptest \
file://0001-cmake-Bump-max-LLVM-version-to-19.patch \
"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you happen to have buildpaths disabled or lowered to WARN_QA?

With ptest enabled I'm seeing (with older 0.20.1 version):
http://errors.yoctoproject.org/Errors/Build/190235/

ERROR: bpftrace-0.20.1+git-r0 do_package_qa: QA Issue: File /usr/lib/bpftrace/ptest/tests/bpftrace_test in package bpftrace-ptest contains reference to TMPDIR [buildpaths]
ERROR: bpftrace-0.20.1+git-r0 do_package_qa: QA Issue: File /usr/lib/bpftrace/ptest/tests/testprogs/cmake_install.cmake in package bpftrace-ptest contains reference to TMPDIR [buildpaths]
ERROR: bpftrace-0.20.1+git-r0 do_package_qa: QA Issue: File /usr/lib/bpftrace/ptest/tests/testprogs/CTestTestfile.cmake in package bpftrace-ptest contains reference to TMPDIR [buildpaths]
ERROR: bpftrace-0.20.1+git-r0 do_package_qa: QA Issue: File /usr/lib/bpftrace/ptest/tests/testlibs/cmake_install.cmake in package bpftrace-ptest contains reference to TMPDIR [buildpaths]
ERROR: bpftrace-0.20.1+git-r0 do_package_qa: QA Issue: File /usr/lib/bpftrace/ptest/tests/testlibs/CTestTestfile.cmake in package bpftrace-ptest contains reference to TMPDIR [buildpaths]
ERROR: bpftrace-0.20.1+git-r0 do_package_qa: QA Issue: File /usr/src/debug/bpftrace/0.20.1+git/parser.tab.hh in package bpftrace-src contains reference to TMPDIR [buildpaths]
ERROR: bpftrace-0.20.1+git-r0 do_package_qa: QA Issue: File /usr/src/debug/bpftrace/0.20.1+git/lex.yy.cc in package bpftrace-src contains reference to TMPDIR [buildpaths]
ERROR: bpftrace-0.20.1+git-r0 do_package_qa: QA Issue: File /usr/src/debug/bpftrace/0.20.1+git/parser.tab.cc in package bpftrace-src contains reference to TMPDIR [buildpaths]
ERROR: bpftrace-0.20.1+git-r0 do_package_qa: QA Issue: File /usr/src/debug/bpftrace/0.20.1+git/location.hh in package bpftrace-src contains reference to TMPDIR [buildpaths]

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes in yoe buildpaths is downgraded to be a warning.

@kraj kraj force-pushed the kraj/clang-19 branch 4 times, most recently from f58697e to 1737e3b Compare September 2, 2024 21:27
@kraj kraj mentioned this pull request Sep 3, 2024
Open
3 tasks
@kraj kraj force-pushed the kraj/clang-19 branch 3 times, most recently from d996339 to bd67b38 Compare September 3, 2024 17:04
@kraj
pbzip2: Do not use libc++ for now
e0b26f7 
it need to be ported to not use generic char_traits

Signed-off-by: Khem Raj <[email protected]>
@kraj
spirv-llvm-translator: Bump to release_190
0d601e3 
Fixes build with clang-19

Signed-off-by: Khem Raj <[email protected]>
shr-project referenced this pull request Sep 11, 2024
@kraj
include-what-you-use: Upgrade to tip of trunk
dda3f8c 
Brings clang-19 support

Signed-off-by: Khem Raj <[email protected]>
@shr-project
Copy link
Contributor

FYI: I've noticed one more small issue introduced by this PR in some multilib builds:

ERROR: QA Issue: lib32-clang: Files/directories were installed but not shipped in any package:
  /usr/lib/libscanbuild
  /usr/lib/libscanbuild/intercept.py
  /usr/lib/libscanbuild/analyze.py
  /usr/lib/libscanbuild/clang.py
  /usr/lib/libscanbuild/report.py
  /usr/lib/libscanbuild/arguments.py
  /usr/lib/libscanbuild/shell.py
  /usr/lib/libscanbuild/compilation.py
  /usr/lib/libscanbuild/__init__.py
  /usr/lib/libscanbuild/resources
  /usr/lib/libscanbuild/resources/sorttable.js
  /usr/lib/libscanbuild/resources/selectable.js
  /usr/lib/libscanbuild/resources/scanview.css
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
lib32-clang: 13 installed and not shipped files. [installed-vs-shipped]

In these builds we use a bit strange libdir /usr/lib32 (instead of usr/lib and usr/lib64), but other parts of clang respect that, only libscanbuild doesn't. Will investigate and send fix (I don't think it should block this PR, it's just FYI).

@shr-project
Copy link
Contributor

installed-vs-shipped QA issue fixed in:
shr-project@ff430da

if you want to pick it to this PR (or I can open separate PR on top of this)

@kraj
Copy link
Owner Author

kraj commented Sep 13, 2024

installed-vs-shipped QA issue fixed in: shr-project@ff430da

if you want to pick it to this PR (or I can open separate PR on top of this)

yeah I have cherry-picked it into clang19 PR and also to my llvm fork.

kraj and others added 7 commits September 17, 2024 14:14
@kraj
clang: Upgrade to 19.1.0 release
96c89a7 
Release Notes below

llvm - https://releases.llvm.org/19.1.0/docs/ReleaseNotes.html
clang - https://releases.llvm.org/19.1.0/tools/clang/docs/ReleaseNotes.html
lld - https://releases.llvm.org/19.1.0/tools/lld/docs/ReleaseNotes.html
libc++ - https://releases.llvm.org/19.1.0/projects/libcxx/docs/ReleaseNotes.html
clang-extra - https://releases.llvm.org/19.1.0/tools/clang/tools/extra/docs/ReleaseNotes.html

Signed-off-by: Khem Raj <[email protected]>
@shr-project @kraj
clang: scan-build-py: respect LLVM_LIBDIR_SUFFIX like other tools do
2da70d9 
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

* fixes:
  ERROR: QA Issue: lib32-clang: Files/directories were installed but not shipped in any package:
    /usr/lib/libscanbuild
    /usr/lib/libscanbuild/intercept.py
    /usr/lib/libscanbuild/analyze.py
    /usr/lib/libscanbuild/clang.py
    /usr/lib/libscanbuild/report.py
    /usr/lib/libscanbuild/arguments.py
    /usr/lib/libscanbuild/shell.py
    /usr/lib/libscanbuild/compilation.py
    /usr/lib/libscanbuild/__init__.py
    /usr/lib/libscanbuild/resources
    /usr/lib/libscanbuild/resources/sorttable.js
    /usr/lib/libscanbuild/resources/selectable.js
    /usr/lib/libscanbuild/resources/scanview.css
  Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
  lib32-clang: 13 installed and not shipped files. [installed-vs-shipped]

  e.g. in multilib build where libdir is set to /usr/lib32 or /usr/lib64.

Signed-off-by: Martin Jansa <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
@kraj
recipes: Use gcc or clang/libstdc++ for some recipes
6b1659f 
These recipes do not yet build with libc++-19, for now
use libstdc++, poco and netdata do not compile with clang-19
at all

Signed-off-by: Khem Raj <[email protected]>
@kraj
libjxl: Use -Og instead of -O2 with clang-19
22345c7 
This is a workaround until [1] is fixed

[1] llvm/llvm-project#108262

Signed-off-by: Khem Raj <[email protected]>
@kraj
lldb: Enable on RISCV64
3b9dacf 
With clang-19 LLDB is building fine for RISCV64

Signed-off-by: Khem Raj <[email protected]>
@kraj
nmap: Remove LLD build workaround for RISCV-64
c327d32 
This is no longer needed with clang-19

Signed-off-by: Khem Raj <[email protected]>
@kraj
python3-drgn: Use gcc when compiling for riscv32
1726e52 
openmp port for riscv32 is not yet available so we
can not use clang for it for now.

Signed-off-by: Khem Raj <[email protected]>
@kraj
python3-cffi: Ad clang to rdeps for ptests to pass
806b9a5 
ptest tries to compile some portions on the target
and demands the compiler that was used to cross-compile it

Signed-off-by: Khem Raj <[email protected]>
@kraj kraj merged commit c6a3ab1 into kraj:master Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shr-project shr-project shr-project left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kraj @shr-project