Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix php_pcre_match_impl with 8.4 #111

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix php_pcre_match_impl with 8.4 #111

wants to merge 1 commit into from

Conversation

remicollet
Copy link
Collaborator

No description provided.

@andypost
Copy link

works good, let's get it in

Copy link

@ghostwriter ghostwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @remicollet!

@cmb69
Copy link
Contributor

cmb69 commented Aug 7, 2024

Works on Windows (MSVC), too.

@Jubeki
Copy link

Jubeki commented Sep 13, 2024

Hey @remicollet thanks for the PR for PHP 8.4 support.

Do you have a timeline for merging / releasing this PR? Will you wait until PHP 8.4 RC1 or GA?

@remicollet
Copy link
Collaborator Author

Do you have a timeline for merging / releasing this PR? Will you wait until PHP 8.4 RC1 or GA?

I always consider it strange to release a new version, stating "Compatible with 8.4" during alpha/beta, which does not have the Final API. So yes, I think it is better to wait for RC1.

BTW, the decision is to the owner, so to @krakjoe

@andypost
Copy link

API bump/fix will happen in 2 weeks with RC1, this is only fix required to work on 8.4 so better to wait final polishing

@andypost
Copy link

RC1 is out and API finally fixed, used to rebuild with this patch and no issues detected

@ghostwriter
Copy link

Joe Watkins aka @krakjoe, needs help.

I encourage you to check out the GoFundMe campaign https://gofund.me/8b6df24f.

Additionally, sharing the story within your networks can help raise awareness and support.

Thank you for taking the time to read this and for any support you can provide!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants