Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch async errors in nested generators #55

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Catch async errors in nested generators #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
307be95
Catch errors thrown by the function result of the call helper
SofianeDjellouli Jul 27, 2020
524fa94
Merge remote-tracking branch 'source/master'
SofianeDjellouli Aug 17, 2020
e4a7834
Test sync functions in nested generators
SofianeDjellouli Aug 17, 2020
7a35757
Remove unnecessary use of call helper
SofianeDjellouli Aug 17, 2020
72333c5
Add test for async throwns in nested generator
SofianeDjellouli Aug 18, 2020
d2312b0
Don't iterate if no result
SofianeDjellouli Aug 18, 2020
d47390a
Add handleGenerator tests
SofianeDjellouli Aug 24, 2020
d576163
Make use of the yield* keyword in nested generators
SofianeDjellouli Aug 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
329 changes: 324 additions & 5 deletions src/helpers/__tests__/handleGenerator.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,340 @@ describe('Given the handleGenerator helper', function () {
});
});

it("should catch errors in the function result of the call helper", function () {
it('should catch errors in the function result of the call helper', function () {
const mistake = () => {
throw new Error("oops");
throw new Error('oops');
};

const generator = function* () {
const generator = function* generator() {
try {
yield call(mistake);
} catch (err) {
return yield call(() => err.message);
return err.message;
}
};

handleGenerator({}, generator(), (result) =>
expect(result).to.be.equal("oops")
expect(result).to.be.equal('oops')
);
});

it('should handle synchronous functions in nested generators', function () {
const synchronous = () => 'synchronous';

const nestedGenerator = function* nestedGenerator () {
return yield call(synchronous);
};

const generator = function* generator() {
try {
return yield call(nestedGenerator);
} catch (err) {
return err.message;
}
};

const onGeneratorEnds = sinon.spy();

handleGenerator({}, generator(), onGeneratorEnds);

expect(onGeneratorEnds).to.be.calledOnce.and.to.be.calledWith('synchronous');
});

it('should catch errors thrown by synchronous functions in nested generators', function () {
const mistake = () => {
throw new Error('oops');
};

const nestedGenerator = function* nestedGenerator () {
yield call(mistake);
};

const afterThrow = sinon.spy();

const generator = function* generator() {
try {
yield call(nestedGenerator);
yield call(afterThrow);
} catch (err) {
return err.message;
}
};

const onGeneratorEnds = sinon.spy();

handleGenerator({}, generator(), onGeneratorEnds);

expect(afterThrow.notCalled).to.be.equal(true);
expect(onGeneratorEnds).to.be.calledOnce.and.to.be.calledWith('oops');
});

it('should handle asynchronous functions in nested generators', function (done) {
const async = async () => await Promise.resolve('async');

const nestedGenerator = function* nestedGenerator () {
return yield call(async);
};

const generator = function* generator() {
try {
return yield call(nestedGenerator);
} catch (err) {
return err.message;
}
};

const onGeneratorEnds = sinon.spy();

handleGenerator({}, generator(), onGeneratorEnds);

setTimeout(function () {
expect(onGeneratorEnds).to.be.calledOnce.and.to.be.calledWith('async');
done();
}, 300);
});

it('should catch errors thrown by asynchronous functions in nested generators', function (done) {
const mistake = async () => {
throw new Error('oops');
};

const nestedGenerator = function* nestedGenerator () {
yield call(mistake);
};

const afterThrow = sinon.spy();

const generator = function* generator() {
try {
yield call(nestedGenerator);
yield call(afterThrow);
} catch (err) {
return err.message;
}
};

expect(afterThrow.notCalled).to.be.equal(true);

const onGeneratorEnds = sinon.spy();

handleGenerator({}, generator(), onGeneratorEnds);

setTimeout(function () {
expect(onGeneratorEnds).to.be.calledOnce.and.to.be.calledWith('oops');
done();
}, 30);
});

it('should catch errors thrown by asynchronous functions in deeply nested generators', function (done) {
const mistake = async () => {
throw new Error('oops');
};

const deepGenerator = function* deepGenerator() {
yield call(mistake);
};

const nestedGenerator = function* nestedGenerator () {
yield call(deepGenerator);
};

const afterThrow = sinon.spy();

const generator = function* generator() {
try {
yield call(nestedGenerator);
yield call(afterThrow);
} catch (err) {
return err.message;
}
};

expect(afterThrow.notCalled).to.be.equal(true);

const onGeneratorEnds = sinon.spy();

handleGenerator({}, generator(), onGeneratorEnds);

setTimeout(function () {
expect(onGeneratorEnds).to.be.calledOnce.and.to.be.calledWith('oops');
done();
}, 30);
});

it('should catch errors thrown by synchronous functions in deeply nested generators', function () {
const mistake = () => {
throw new Error('oops');
};

const deepGenerator = function* deepGenerator() {
yield call(mistake);
};

const nestedGenerator = function* nestedGenerator () {
yield call(deepGenerator);
};

const afterThrow = sinon.spy();

const generator = function* generator() {
try {
yield call(nestedGenerator);
yield call(afterThrow);
} catch (err) {
return err.message;
}
};

const onGeneratorEnds = sinon.spy();

handleGenerator({}, generator(), onGeneratorEnds);

expect(afterThrow.notCalled).to.be.equal(true);
expect(onGeneratorEnds).to.be.calledOnce.and.to.be.calledWith('oops');
});

it('should handle synchronous functions in deeply nested generators', function () {
const synchronous = () => 'synchronous';

const deepGenerator = function* deepGenerator() {
return yield call(synchronous);
};

const nestedGenerator = function* nestedGenerator () {
return yield call(deepGenerator);
};

const generator = function* generator() {
try {
return yield call(nestedGenerator);
} catch (err) {
return err.message;
}
};
const onGeneratorEnds = sinon.spy();

handleGenerator({}, generator(), onGeneratorEnds);

expect(onGeneratorEnds).to.be.calledOnce.and.to.be.calledWith('synchronous');
});

it('should handle asynchronous functions in deeply nested generators', function (done) {
const async = async () => await Promise.resolve('async');

const deepGenerator = function* deepGenerator() {
return yield call(async);
};

const nestedGenerator = function* nestedGenerator () {
return yield call(deepGenerator);
};

const generator = function* generator() {
try {
return yield call(nestedGenerator);
} catch (err) {
return err.message;
}
};

const onGeneratorEnds = sinon.spy();

handleGenerator({}, generator(), onGeneratorEnds);

setTimeout(function () {
expect(onGeneratorEnds).to.be.calledOnce.and.to.be.calledWith('async');
done();
}, 300);
});

it('should handle asynchronous functions', function (done) {
const async = async () => await Promise.resolve('async');

const generator = function* generator() {
try {
return yield call(async);
} catch (err) {
return err.message;
}
};

const onGeneratorEnds = sinon.spy();

handleGenerator({}, generator(), onGeneratorEnds);

setTimeout(function () {
expect(onGeneratorEnds).to.be.calledOnce.and.to.be.calledWith('async');
done();
}, 300);
});

it('should catch errors in asynchronous functions', function (done) {
const mistake = async () => {
throw new Error('oops');
};
const afterThrow = sinon.spy();

const generator = function* generator() {
try {
yield call(mistake);
yield call(afterThrow);
} catch (err) {
return err.message;
}
};

const onGeneratorEnds = sinon.spy();

handleGenerator({}, generator(), onGeneratorEnds);

setTimeout(function () {
expect(onGeneratorEnds).to.be.calledOnce.and.to.be.calledWith('oops');
expect(afterThrow.notCalled).to.be.equal(true);

done();
}, 300);
});

it('should handle synchronous functions', function () {
const synchronous = () => 'synchronous';

const generator = function* generator() {
try {
return yield call(synchronous);
} catch (err) {
return err.message;
}
};

const onGeneratorEnds = sinon.spy();

handleGenerator({}, generator(), onGeneratorEnds);

expect(onGeneratorEnds).to.be.calledOnce.and.to.be.calledWith('synchronous');
});

it('should catch errors thrown by synchronous functions', function () {
const mistake = () => {
throw new Error('oops');
};

const afterThrow = sinon.spy();

const generator = function* generator() {
try {
yield call(mistake);
yield call(afterThrow);
} catch (err) {
return err.message;
}
};

const onGeneratorEnds = sinon.spy();

handleGenerator({}, generator(), onGeneratorEnds);

expect(afterThrow.notCalled).to.be.equal(true);
expect(onGeneratorEnds).to.be.calledOnce.and.to.be.calledWith('oops');
});
});
Loading