Clicking back and forth between nodes loses edits. #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edits whenever a node was moved. Since position handle sometimes fires when clicking on a node, just clicking back and forth could corrupt node configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another tab related state issues: Clicking back and forth between nodes loses edits.
OnNodeDragStophandler was updating with stale data. This would result in nodes reverting to the state from when they were initially loaded from the API. Changes were reflected in the database, but UI was stale.Changes
OnNodeDragStopnow uses updated stateHow Tested
[Explain how you tested this pull request. Include any relevant steps or scripts.]
TODOs
[List any outstanding TODOs or known issues that still need to be addressed.]