Artifacts content is now written as expected #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A last minute change for
SaveArtifactschain broke file writes. Files were displayed correctly in the UX but as a JSON objectin the filesystem
Changes
SaveArtifactnow only serializes content when content is not already a stringCoder v1now setsSaveArtifact.content_pathto properly map content to fileArtifactContentto expect amessage.datato be astrinstead of json.How Tested
SaveArtifact.content_pathTODOs
[List any outstanding TODOs or known issues that still need to be addressed.]