Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exclude option #20

Closed
shaharkazaz opened this issue Aug 13, 2020 · 2 comments · Fixed by #28
Closed

Add exclude option #20

shaharkazaz opened this issue Aug 13, 2020 · 2 comments · Fixed by #28
Assignees
@shaharkazaz
Labels
enhancement New feature or request released

Comments

@shaharkazaz
Copy link
Collaborator

shaharkazaz commented Aug 13, 2020 •
edited
Loading

Allow excluding files/paths in the following ways:

  • Add a new config property ignore which accepts file paths/glob regexes.
  • Detect and ignore via a comment in the file: // import-conductor-ignore
@shaharkazaz shaharkazaz self-assigned this Aug 20, 2020
@shaharkazaz shaharkazaz added the enhancement New feature or request label Aug 20, 2020
@ericaskari
Copy link

Hi, Thanks for this awesome library, I already integrated it with File watcher of my IDE Webstorm which runs it on save.
although I faced a problem which this enhancement will fix it.
in a Typescript project I use TypeDi for dependency injection and I need to reflect-metadata be the first line but after running the plugin it will be pushed to third line.

import 'reflect-metadata';

I'll be eagerly waiting for this ☺️

shaharkazaz added a commit that referenced this issue Aug 29, 2020
@shaharkazaz
feat: 🎸 support ignore files and dry run
4a28554 
Also made some infra changes

BREAKING CHANGE: 🧨 config options

✅ Closes: #20
@nivekcode nivekcode linked a pull request Aug 29, 2020 that will close this issue
Feature/exclude files #28
Merged
nivekcode pushed a commit that referenced this issue Aug 29, 2020
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
07ebac4 
# [2.0.0](v1.5.1...v2.0.0) (2020-08-29)

### Features

* 🎸 support ignore files and dry run ([4a28554](4a28554)), closes [#20](#20)

### BREAKING CHANGES

* 🧨 config options
@nivekcode
Copy link
Owner

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaharkazaz shaharkazaz

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/exclude files nivekcode/import-conductor
3 participants
@nivekcode @shaharkazaz @ericaskari