Feature/exclude files #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shaharkazaz
commented
Aug 29, 2020
•
shaharkazaz
commented
- Allow skipping files
- Add dry run option
- Refactor configuration options (Breaking)
- Infra changes
- Fixed playground
Also made some infra changes BREAKING CHANGE: 🧨 config options ✅ Closes: #20
nivekcode
reviewed
Aug 29, 2020
nivekcode
reviewed
Aug 29, 2020
There was a problem hiding this comment.
Fantastic work @shaharkazaz!
I left a couple of nodes as improvements.
src/conductor/optimize-imports.ts
Outdated
| return actions.none; | ||
| } | ||
|
|
||
| const fileContent = readFileSync(filePath); |
There was a problem hiding this comment.
could we do this earlier? - like we shouldn't optimize the imports at all if the file is ignored.
There was a problem hiding this comment.
we are not optimizing if he is ignored (we return with actions.skipped), I'm not sure what you mean.
Closed
nivekcode
approved these changes
Aug 29, 2020
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.