feat: migrate to tf-sdk2

[mavogel]

Steps

see https://www.terraform.io/docs/extend/guides/v2-upgrade-guide.html

• pass ctx to all methods
• fix linters
• fix unit tests
• fix builds. Need to update docker dependencies. See chore: bump docker dependency to v20.10.5 #119
• fix linters after update and rebasing
• fix acceptance tests
• replace ValidateFunc with ValidateDiagFunc
• continue with the upgrade guide and add new best practices for sdk v2 -> will be done in refactor: do full internal refactoring  #94
• move website to docs directory. uses index.md -> will be done in refactor: do full internal refactoring  #94

Notes

• we will not update to ValidateDiagFunc until feat: add example of usage of ValidateDiagFunc hashicorp/terraform-provider-scaffolding#47 is solved -> got solved. Will add it

[innovate-invent]

Have a look at some of the changes in #23. You will need to actually use the new context param for it to be effective.

[mavogel]

Thanks for pointing out! I made the rough changes yesterday and now I'll go for the details

[suzuki-shunsuke]

State Migration should be implemented.

[suzuki-shunsuke]

https://www.terraform.io/docs/extend/resources/state-migration.html#terraform-v0-12-sdk-state-migrations

[mavogel]

Thanks for pointing out :) So for all TypeMap to TypeList we need those migrators right?

[suzuki-shunsuke]

I think so.

[mavogel]

• tested locally with unit tests and
• as described in the contributing section (I wonder how we can automate those tests)

terraform {
  required_providers {
    docker = {
      source  = "kreuzwerker/docker"
      #version = "2.8.0"
      version = "9.9.9"
    }
  }
}

provider "docker" {
}

resource "docker_image" "foo" {
  name         = "nginx:latest"
  keep_locally = true
}

resource "docker_service" "foo" {
  name = "foo"
  task_spec {
    container_spec {
      image             = docker_image.foo.latest
      stop_grace_period = "10s"
    }
    # v2.8.0
    #restart_policy = { 
    # v9.9.9
    restart_policy {
      condition    = "on-failure"
      delay        = "3s"
      max_attempts = 4
      window       = "10s"
    }

  }

  endpoint_spec {
    ports {
      target_port    = "80"
      published_port = "8080"
    }
  }
}

[suzuki-shunsuke]

Great work!
Would you split files per schema version like docker_container resource?

• resource_docker_service.go
• resource_docker_service_v1.go
• resource_docker_service_v0.go

I did the same in thing hashicorp/terraform-provider-docker#272 .

[suzuki-shunsuke]

Is it required to move docker package to internal/provider for SDK migration?

[suzuki-shunsuke]

Great work!

IMHO, we should do one thing in one pull request.
In case of this pull request, we should do only SDK migration in this pull request, and refactoring and bug fixes which are unrelated to the SDK migration should be done in the other pull requests.

I don't think we should split this pull request forcibly because it is hard,
but I wrote this comment for the future work.

[mavogel]

Is it required to move docker package to internal/provider for SDK migration?

I wanted to be consistent with the latest scaffolder

[suzuki-shunsuke]

I wanted to be consistent with the latest scaffolder

I got it. Looks Good.

[mavogel]

Feel free to leave a final review @suzuki-shunsuke :)

[suzuki-shunsuke]

🚀

[suzuki-shunsuke]

I can't merge this pull request.
I think we should fix the branch protection rule although I don't have the permission.