Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Docker plugin #35
feat: support Docker plugin #35
Changes from 18 commits
6c0434e
2238594
c0fc9db
ceae7b1
1c1ba51
963699b
bbd50ed
260a2ef
1f7e286
731342a
593269b
84dd122
3b7ab72
a9662ad
6522a35
7a79c28
908fd7c
9df6394
e52b264
5f925d6
54629cc
afcb76c
3ec71c5
c8b9c7f
967f2ba
03b2187
735df8a
0d31498
bc2a157
3a8e2b0
abec1d5
17d8fc6
e3384e9
7a7aee3
b82956b
e0ce386
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should implement AcceptPermissionsFunc that matches against permissions listed in a resource attribute that ConfictsWith "grant_all_permissions"
https://pkg.go.dev/github.com/docker/docker/api/types#PluginInstallOptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why this comment is being hidden but it is vital to the initial implementation. For production use grant_all_permissions must be false and the permissions need to be explicitly provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suzuki-shunsuke can you take a look, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added an attribute
grant_permissions
.03b2187
TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Env is not the correct value for Args.
You need to implement all of https://pkg.go.dev/github.com/docker/docker/api/types#PluginSettings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I misunderstood the purpose of this value. You might want to change the attribute to
env
to make clear what it is doing.