Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose sqlite3 debugging hooks #48

Merged
merged 1 commit into from
Nov 23, 2017
Merged

Expose sqlite3 debugging hooks #48

merged 1 commit into from
Nov 23, 2017

Conversation

mike-north
Copy link
Contributor

Without exposing the whole sqlite3 driver, this small change allows registration of trace and profile hooks.

More info: https://github.com/mapbox/node-sqlite3/wiki/Debugging

theogravity
theogravity requested changes Nov 23, 2017
View reviewed changes
Copy link
Collaborator

@theogravity theogravity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine but you need to fix the issues found on the Travis build.

@mike-north
Copy link
Contributor Author

ESLint is happy now

@theogravity theogravity merged commit 89b4404 into kriasoft:master Nov 23, 2017
@mike-north mike-north deleted the sqlite3-debugging-hooks branch November 23, 2017 09:21
@theogravity
Copy link
Collaborator

Published under 2.9.1. Sorry for massive delay, no excuses here, just forgot that I needed to publish :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theogravity theogravity theogravity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike-north @theogravity