Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update sqlite3 version supporting for node 11 and electron osx 3.0 #85

Closed
wants to merge 1 commit into from
Closed

feat: update sqlite3 version supporting for node 11 and electron osx 3.0 #85

wants to merge 1 commit into from

Conversation

yugasun
Copy link

@yugasun yugasun commented Dec 17, 2018

@frenzzy
Copy link
Member

frenzzy commented Dec 24, 2018

There are ^4.0.0 in package.json already which means you can use any version since 4.0.0 and up to 5.0.0, just update your local version. For example you can uninstall the package and install it again to use the latest version and update your package-lock.json file.

@yugasun
Copy link
Author

yugasun commented Dec 25, 2018

@frenzzy But, you can find the sqlite3 version is locked in yarn.lock file, so this pr is still a need.

@frenzzy
Copy link
Member

frenzzy commented Dec 25, 2018

yarn.lock file is not included into npm package: https://unpkg.com/[email protected]/
so, for users it does not matter what this file contains.

maybe add yarn.lock to .gitignore not to mislead anyone and keep repo clean...

@yugasun
Copy link
Author

yugasun commented Dec 25, 2018

@frenzzy You are right, we can put yarn.lock into .gitignore, but I still suggest to update the sqlite3 version and add yarn.lock into npm package for safety. Because when installing it, different sqlite3 version may comes out in different environment.

@aashna208
Copy link

Hi, Is there any way to use this package with electron app?

@saeta-eth
Copy link

@aashna208 Yes, I'm using this library with electron and seems to be working. Have you tried it?

@theogravity
Copy link
Collaborator

If you are still having problems, please try out the v4 beta (see the issues main for more info)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants