Fix CI workflow deprecation errors #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes errors from deprecated `add-path` and `set-env`
Try running cmake before setup-emsdk to verify that setup-emsdk is not corrupting the environment on windows 2019 runners
|
I found that setup-emsdk can corrupt |
ianpurvis
changed the title
|
@kripken Quick heads-up, I'm going to merge this fix for CI. |
|
Thanks @ianpurvis , sorry for the delay in getting to this. |
|
@kripken All good- thanks!! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build errors from deprecated
add-pathandset-envsurfacing in #352More info at https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/