Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property 'intercept' in type 'DataLoaderInterceptor' is not assignable to the same property in base type 'NestInterceptor<any, any>'. #50

Open
sajid-ad opened this issue May 25, 2021 · 3 comments · Fixed by dantehemerson/nestjs-dataloader#5 · May be fixed by #51

Comments

@sajid-ad
Copy link

sajid-ad commented May 25, 2021

Seems like the nestjs-dataloader is outdated, it's not compatible with nest latest version. After updated to nest latest version I am getting an error.

below are the version details
Node version => v14.16.0
NPM version => 6.14.11

@nestjs/common = > 7.6.17
@nestjs/core => 7.6.17
@nestjs/graphql => 7.10.6
@nestjs/microservices => 7.6.17
@nestjs/platform-express => 7.6.17
nestjs-dataloader => 7.0.1

error details

Property 'intercept' in type 'DataLoaderInterceptor' is not assignable to the same property in base type 'NestInterceptor<any, any>'.
Type '(context: ExecutionContext, next: CallHandler<any>) => Observable<any>' is not assignable to type '(context: ExecutionContext, next: CallHandler<any>) => Observable<any> | Promise<Observable<any>>'.
Type 'Observable<any>' is not assignable to type 'Observable<any> | Promise<Observable<any>>'.
Property '_deprecatedSyncErrorSubscribe' is missing in type 'import("/Users/mac/Desktop/Projects/NodeJs/rubix/retail/middleware/videocall.service/node_modules/nestjs-dataloader/node_modules/rxjs/internal/Observable").Observable<any>' but required in type 'import("/Users/mac/Desktop/Projects/NodeJs/rubix/retail/middleware/videocall.service/node_modules/rxjs/dist/types/internal/Observable").Observable<any>'.

intercept(context: ExecutionContext, next: CallHandler): Observable<any> {
private _deprecatedSyncErrorSubscribe;
'_deprecatedSyncErrorSubscribe' is declared here.

Type 'Observable<any>' is missing the following properties from type 'Observable<any>': _isScalar, _trySubscribe, _subscribe
return next.handle();

JonnyBGod added a commit to JonnyBGod/nestjs-dataloader that referenced this issue Jun 16, 2021
@JonnyBGod JonnyBGod linked a pull request Jun 16, 2021 that will close this issue
@JejeDurden
Copy link

Thanks for the fix @JonnyBGod ! Do you know when it is going to be merged and released ?

@curtainTan
Copy link

same problem

simenandre pushed a commit to simenandre/nestjs-dataloader that referenced this issue Oct 2, 2021
@jonapgartwohat
Copy link

lol I should have looked at the issues before opening my PR 🙄

#53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants