Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate if GraphQL Context exists for another Execution Contexts #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dantehemerson
Copy link
Contributor

Fix #22
Since the interceptor is injecting globally, we must validate that the GraphQL context exists.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 106805450

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 83.333%

Totals Coverage Status
Change from base Build 103164194: 1.2%
Covered Lines: 20
Relevant Lines: 22

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 106805450

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 83.333%

Totals Coverage Status
Change from base Build 103164194: 1.2%
Covered Lines: 20
Relevant Lines: 22

💛 - Coveralls

@hamxabaig
Copy link

@krislefeber can you please merge it? It's happening to us as well. We are not able to move fwd. By the way, love the package & thanks for all the effort 🎉

Copy link

@hamxabaig hamxabaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@junaidcs
Copy link

Screenshot 2020-10-14 at 11 38 46 AM

@krislefeber getting error due to this, please merge this PR. Thanks

Copy link

@junaidcs junaidcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinhnguyen1211
Copy link

Let's merge it

Copy link

@sujamess sujamess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Please merge this

@dantehemerson
Copy link
Contributor Author

Hi folks. Seems that this repository has not been maintained for a long time. So in the meantime, I have created a new repository to add this feature.

The fix version is: https://github.com/dantehemerson/nestjs-dataloader/releases/tag/v1.0.1
Npm Package: https://www.npmjs.com/package/@dantehemerson/nestjs-dataloader
You can install it by doing: npm i @dantehemerson/nestjs-dataloader

@coveralls
Copy link

coveralls commented Jul 27, 2024

Pull Request Test Coverage Report for Build 106805450

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 83.333%

Totals Coverage Status
Change from base Build 103164194: 1.2%
Covered Lines: 20
Relevant Lines: 22

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataloader executing in HttpRequest with empty context in NestJSv7
10 participants