-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate if GraphQL Context exists for another Execution Contexts #26
base: master
Are you sure you want to change the base?
Validate if GraphQL Context exists for another Execution Contexts #26
Conversation
Pull Request Test Coverage Report for Build 106805450
💛 - Coveralls |
Pull Request Test Coverage Report for Build 106805450
💛 - Coveralls |
@krislefeber can you please merge it? It's happening to us as well. We are not able to move fwd. By the way, love the package & thanks for all the effort 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
@krislefeber getting error due to this, please merge this PR. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 Please merge this
Hi folks. Seems that this repository has not been maintained for a long time. So in the meantime, I have created a new repository to add this feature. The fix version is: https://github.com/dantehemerson/nestjs-dataloader/releases/tag/v1.0.1 |
Pull Request Test Coverage Report for Build 106805450Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Fix #22
Since the interceptor is injecting globally, we must validate that the GraphQL context exists.