Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow configuring tooltip for interactive guideline #222

Merged
merged 1 commit into from
Sep 10, 2015
Merged

allow configuring tooltip for interactive guideline #222

merged 1 commit into from
Sep 10, 2015

Conversation

pgrm
Copy link
Contributor

@pgrm pgrm commented Sep 9, 2015

When defining valueFormatter for the tooltip in interactive guideline, than it needs to be done recursively, hence:

} else if (key === 'tooltip') {
  configure(chart[key], options[key], chartType);
}

@pgrm
Copy link
Contributor Author

pgrm commented Sep 9, 2015

btw, in order for this to work, novus/nvd3#1247 also needs to be addressed in nvd3, as I've changed it here: https://github.com/grmanit/nvd3/commit/23be42942d8c6c06cd679d2a6cbb8e033846d7e4

krispo added a commit that referenced this pull request Sep 10, 2015
allow configuring tooltip for interactive guideline
@krispo krispo merged commit 1c5dafd into krispo:master Sep 10, 2015
@krispo
Copy link
Owner

krispo commented Sep 10, 2015

Thanks! I'll update this a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants