Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no_std support on nightly #51

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Conversation

domenukk
Copy link
Contributor

@domenukk domenukk commented May 9, 2023

This PR adds no_std support using the unstable ip_in_core and error_in_core features.
(Cleaned up version of #49 )

@domenukk domenukk force-pushed the no_std_again branch 2 times, most recently from 94c3bd2 to 12d76cc Compare May 10, 2023 16:55
@domenukk
Copy link
Contributor Author

@krisprice does the PR look good to you like this?

@krisprice
Copy link
Owner

krisprice commented Jun 11, 2023

Thanks @domenukk, if I run a cargo test --all-features it spits a number of errors, can you run and then resolve those errors?

@domenukk
Copy link
Contributor Author

Good catch, some imports were missing. Fixed :)

@domenukk
Copy link
Contributor Author

Everything good now? Thanks :)

@krisprice krisprice merged commit 02c371f into krisprice:master Jun 26, 2023
@krisprice
Copy link
Owner

Merged and published. Thanks for the work. :-)

@domenukk domenukk deleted the no_std_again branch June 27, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants