Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for catching errors during iteration #303

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

kriszyp
Copy link
Owner

@kriszyp kriszyp commented Aug 28, 2024

Add support for catching errors during iteration and allowing iteration to continue.

@kriszyp kriszyp changed the title Add support for catching errors during iteration and allowing iterati… Add support for catching errors during iteration Aug 28, 2024
@@ -354,22 +354,22 @@ describe('lmdb-js', function () {
should.equal(db.get('key1'), 'done!');
}
});
if (version.patch >= 90)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some spurious lint/write-space updates, really the RangeIterable suite is important test that was added/updated.

Copy link
Collaborator

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kriszyp kriszyp merged commit 3fe3635 into master Aug 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants