Skip to content

Commit

Permalink
use raw.githubusercontent.com for values and argocd manifests
Browse files Browse the repository at this point in the history
  • Loading branch information
kromanow94 committed Mar 22, 2024
1 parent c4d1529 commit 7160211
Show file tree
Hide file tree
Showing 6 changed files with 29 additions and 26 deletions.
2 changes: 1 addition & 1 deletion charts/kubeflow/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.2
version: 0.1.3

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 1 addition & 1 deletion example/helm/app.kubeflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ spec:
source:
chart: kubeflow
repoURL: https://kromanow94.github.io/kubeflow-manifests
targetRevision: 0.1.2
targetRevision: 0.1.3
ignoreDifferences:
- group: rbac.authorization.k8s.io
kind: ClusterRole
Expand Down
4 changes: 2 additions & 2 deletions example/helm/quickstart.apps-of-apps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ required for using sync-waves for ArgoCD Apps and deploy App of Apps manifest
for kubeflow and it's dependencies.
If you only want to apply the App of Apps manifest, cancel this script and execute:
$ kubectl apply -f https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.2/example/helm/app.app-of-apps.yaml
$ kubectl apply -f https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/app.app-of-apps.yaml
Press 'Ctrl'+'C' to cancel.
Waiting 10 seconds...
Expand Down Expand Up @@ -42,4 +42,4 @@ data:

kubectl wait pods --namespace argocd --all --for=condition=Ready --timeout 300s

kubectl apply -f app.app-of-apps.yaml
kubectl apply -f https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/app.app-of-apps.yaml
24 changes: 12 additions & 12 deletions example/helm/quickstart.argocd.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ else
fi

set -x
kubectl apply -f app.mysql.yaml
kubectl apply -f app.minio.yaml
kubectl apply -f app.cert-manager.yaml
kubectl apply -f app.dex.yaml
kubectl apply -f app.istio-base.yaml
kubectl apply -f app.istiod.yaml
kubectl apply -f app.metacontroller.yaml
kubectl apply -f https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/app.mysql.yaml
kubectl apply -f https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/app.minio.yaml
kubectl apply -f https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/app.cert-manager.yaml
kubectl apply -f https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/app.dex.yaml
kubectl apply -f https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/app.istio-base.yaml
kubectl apply -f https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/app.istiod.yaml
kubectl apply -f https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/app.metacontroller.yaml
set +x

# Wait until pods are created. This is not required since ArgoCD will be
Expand All @@ -41,9 +41,9 @@ sleep 30
kubectl wait pods --all -n kubeflow --for=condition=Ready --timeout 300s

set -x
kubectl apply -f app.argo-workflows.yaml
kubectl apply -f app.istio-ingressgateway.yaml
kubectl apply -f app.kubeflow.yaml
kubectl apply -f https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/app.argo-workflows.yaml
kubectl apply -f https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/app.istio-ingressgateway.yaml
kubectl apply -f https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/app.kubeflow.yaml
set +x

# Wait until pods are created. This is not required since ArgoCD will be
Expand All @@ -53,15 +53,15 @@ sleep 10
kubectl wait pods --all --namespace kubeflow --for=condition=Ready --timeout 300s

set -x
kubectl apply -f app.profile-kubeflow-user-example-com.yaml
kubectl apply -f https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/app.profile-kubeflow-user-example-com.yaml
set +x

# When deployed with in-cluster self-signed OIDC Issuer (kind, vcluster,
# minikube and so on), oauth2-proxy has to wait for CRB allowing accessing OIDC
# Discovery endpoint from anonymous user. This is condifured by kubeflow helm
# chart.
set -x
kubectl apply -f app.oauth2-proxy.yaml
kubectl apply -f https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/app.oauth2-proxy.yaml
set +x

# Wait until pods are created. This is not required since ArgoCD will be
Expand Down
1 change: 1 addition & 0 deletions example/helm/quickstart.helm.eks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ set -e

cat <<EOF
WARNING: This script is for reference only and will not work out of the box.
Also, it assumes the script is run from a locally cloned git repository.
'kubeflow' and 'oauth2-proxy' Helm Charts needs to be parameterized for AWS IAM
OIDC Issuer to enable access through M2M Service Account Tokens.
Expand Down
22 changes: 12 additions & 10 deletions example/helm/quickstart.helm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,30 +27,30 @@ helm upgrade --install mysql mysql \
--namespace kubeflow \
--repo https://charts.bitnami.com/bitnami \
--version 9.21.2 \
--values values.mysql.yaml \
--values https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/values.mysql.yaml \
--wait

helm upgrade --install minio minio \
--namespace kubeflow \
--repo https://charts.bitnami.com/bitnami \
--version 13.7.0 \
--values values.minio.yaml \
--values https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/values.minio.yaml \
--wait

helm upgrade --install cert-manager cert-manager \
--namespace cert-manager \
--create-namespace \
--repo https://charts.jetstack.io \
--version v1.14.3 \
--values values.cert-manager.yaml \
--values https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/values.cert-manager.yaml \
--wait

helm upgrade --install dex dex \
--namespace dex \
--create-namespace \
--repo https://charts.dexidp.io \
--version 0.16.0 \
--values values.dex.yaml \
--values https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/values.dex.yaml \
--wait

helm upgrade --install istio-base base \
Expand All @@ -64,22 +64,22 @@ helm upgrade --install istiod istiod \
--namespace istio-system \
--repo https://istio-release.storage.googleapis.com/charts \
--version 1.20.2 \
--values values.istiod.yaml \
--values https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/values.istiod.yaml \
--wait

helm upgrade --install istio-ingressgateway gateway \
--namespace istio-ingress \
--create-namespace \
--repo https://istio-release.storage.googleapis.com/charts \
--version 1.20.2 \
--values values.istio-ingressgateway.yaml \
--values https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/values.istio-ingressgateway.yaml \
--wait

helm upgrade --install metacontroller oci://ghcr.io/metacontroller/metacontroller-helm \
--namespace metacontroller \
--create-namespace \
--version v2.6.1 \
--values values.metacontroller.yaml \
--values https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/values.metacontroller.yaml \
--wait

# This Helm Chart Release depends on a mysql secret deployed as part of the Kubeflow
Expand All @@ -91,10 +91,12 @@ helm upgrade --install argo-workflows argo-workflows \
--namespace kubeflow \
--repo https://argoproj.github.io/argo-helm \
--version 0.17.1 \
--values values.argo-workflows.yaml
--values https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/values.argo-workflows.yaml

helm upgrade --install kubeflow ../../charts/kubeflow \
helm upgrade --install kubeflow kubeflow \
--namespace kubeflow \
--repo https://kromanow94.github.io/kubeflow-manifests \
--version 0.1.3 \
--wait

# This is just one object.
Expand All @@ -109,5 +111,5 @@ helm upgrade --install oauth2-proxy oauth2-proxy \
--create-namespace \
--repo https://oauth2-proxy.github.io/manifests \
--version 6.24.1 \
--values values.oauth2-proxy.yaml \
--values https://raw.githubusercontent.com/kromanow94/kubeflow-manifests/kubeflow-0.1.3/example/helm/values.oauth2-proxy.yaml \
--wait

0 comments on commit 7160211

Please sign in to comment.