Added Salsa20 cipher and simplified ChaCha20 #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is runtime performance difference? |
|
I've got an average difference of 26ms on iOS and 35ms on Mac. Both quicker than the previous implementation. |
|
@rogerxaic By how many percent? |
|
Between 2 and 3 percent if I recall correctly. |
# Conflicts: # Sources/CryptoSwift/ChaCha20.swift
Added Rotate left function which takes a value (a) to rotate and an amount (b) to rotate the value (a). The function returns the rotated (a).
rogerxaic
changed the title
Repository owner
deleted a comment
Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Changes proposed in this pull request: