Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for old versions of Ruby #202

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

jlduran
Copy link
Collaborator

@jlduran jlduran commented Oct 16, 2024

No description provided.

@dblock
Copy link
Collaborator

dblock commented Oct 17, 2024

Should we major increment the version of the gem here? Is it time for a 1.0? :)

@jlduran
Copy link
Collaborator Author

jlduran commented Oct 17, 2024

Hmmm... I agree this change should warrant a MAJOR version bump.
Ideally we should align to i18n versioning, but that could be further discussed.

@dblock
Copy link
Collaborator

dblock commented Oct 17, 2024

Your call! Feel free to merge this one without any version changes.

@jlduran
Copy link
Collaborator Author

jlduran commented Oct 17, 2024

OK, I'll commit this one (I'll just change the minimum required version for i18n in the README).
Thank you!

@jlduran jlduran merged commit 7459190 into kslazarev:master Oct 17, 2024
5 checks passed
@jlduran jlduran deleted the bump-ruby branch October 17, 2024 16:12
jlduran added a commit to jlduran/numbers_and_words that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants