Remove all warnings in gem. (ruby -w) #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nyway, and the setter is never used. This eliminates a warning that previously triggered when requiring numbers_and_words because of the overriding.
|
@nikhaldi Yes, attr_accessor :languages is unnecessary (and could be remove in next release). |
|
I sometimes run unit tests with -w for my own code, that's how I came across this warning. I didn't see others in my usage of your gem |
|
@nikhaldi But numbers_and_words's integration tests have many warnings. I'll see them later. Thank you for report. |
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be unused and actually generated this warning upon requiring numbers_and_words (in Ruby 1.9.3):
ruby-1.9.3-p327/gems/numbers_and_words-0.7.1/lib/numbers_and_words/i18n/initialization.rb:13: warning: method redefined; discarding old languages
This fix eliminates the warning.