Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ crash hook fixes #379

Merged
merged 4 commits into from
Jun 24, 2020
Merged

C++ crash hook fixes #379

merged 4 commits into from
Jun 24, 2020

Conversation

GLinnik21
Copy link
Collaborator

Prevented tail call optimisation to gain constant stack frames number in backtrace.

@GLinnik21
Copy link
Collaborator Author

@kstenerud what do you think about -fno-optimize-sibling-calls compiler flag?
TCO also affected kssc_initSelfThread->kssc_initWithBacktrace calls previously.

@kstenerud
Copy link
Owner

Yup, don't see any problems with that. KSCrash itself doesn't need optimize-at-all-costs since it's never going to be the critical path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants