Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write logs in the buffer first to ensure the order of log entries #508

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Write logs in the buffer first to ensure the order of log entries #508

merged 4 commits into from
Jun 21, 2024

Conversation

xuezhulian
Copy link
Contributor

@xuezhulian xuezhulian commented Jun 21, 2024 •
edited
Loading

#479 caused this bug.

@GLinnik21 GLinnik21 mentioned this pull request Jun 21, 2024
Merged
@GLinnik21
Copy link
Collaborator

I've added some tests in #509 to make sure this fix works. I've disabled them to keep the tests green in master, so you'll need to revert this 0283bd1 commit to enable them again.

@GLinnik21 GLinnik21 merged commit 901cfdc into kstenerud:master Jun 21, 2024
19 checks passed
@GLinnik21
Copy link
Collaborator

Thank you very much!

GLinnik21 pushed a commit that referenced this pull request Jun 21, 2024
@xuezhulian @GLinnik21
Write logs in the buffer first to ensure the order of log entries (#508)
fd0360b 
# Conflicts:
#	.swiftpm/xcode/xcshareddata/xcschemes/KSCrash-Package.xcscheme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuezhulian @GLinnik21