Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install screen to samples #528

Merged
merged 7 commits into from
Jul 21, 2024
Merged

Add install screen to samples #528

merged 7 commits into from
Jul 21, 2024

Conversation

bamx23
Copy link
Collaborator

@bamx23 bamx23 commented Jul 7, 2024

Adds an installation screen with most of the config options available. Missing options are marked with TODOs.

kscrash_demo_528.mp4

@bamx23 bamx23 changed the title Extend samples Add install screen to samples Jul 20, 2024
@bamx23 bamx23 requested a review from GLinnik21 July 20, 2024 16:18
@bamx23 bamx23 marked this pull request as ready for review July 20, 2024 16:47
Copy link
Collaborator

@GLinnik21 GLinnik21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! I am really impressed with this Installation UI, especially with the MonitorType screen.

@bamx23 bamx23 merged commit dd0616e into master Jul 21, 2024
5 checks passed
@bamx23 bamx23 deleted the extend-samples branch July 21, 2024 23:48
sweetloser pushed a commit to sweetloser/KSCrash that referenced this pull request Sep 18, 2024
* Add installation config view

* Fix rebase and tune the install screen

* Add user info input

* Add todo's for next steps

* Fix macOS, tvOS and watchOS samples

* Address comments

* Fix header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants