chore: rename file and swap in ruff workflow #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IndexSeek can you remove the old ruff build? |
IndexSeek
force-pushed
the
rename-file-and-fix-ci-steps
branch
from
d6e6960
to
49f01b9
Compare
Sure, good catch! I forgot to force-push the amend commit; sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I renamed "test_y.py" to "test_benchmark.py" to conclude on #40 (comment). I always overthink renaming things, so open to using another name if there is a better fit!
When I was looking at the "pylint" workflow file yesterday, I noticed I left some pylint references from the GitHub Action template I used to scaffold it up. I started researching a bit more and realized that Astral provides a ruff-action out of the box that does
ruff checkby default. It's fairly new, so I understand if we don't want to go with this. If we want to keep the older one, I'd like to rename it and fix the name of the step referencing pylint so it better aligns with it's purpose.