Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix installation instructions #3

Open
wants to merge 2 commits into
base: source
Choose a base branch
from
Open

fix installation instructions #3

wants to merge 2 commits into from

Conversation

maty21
Copy link
Member

@maty21 maty21 commented Jun 18, 2019 •
edited
Loading

This change is Reviewable

@maty21 maty21 requested a review from yehiyam June 18, 2019 13:42
yehiyam
yehiyam requested changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @maty21 and @yehiyam)

site/learn/API.md, line 31 at r1 (raw file):

api-server

without the api server

yehiyam
yehiyam reviewed Jun 18, 2019
View reviewed changes
Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without /api-server

@maty21
Copy link
Member Author

maty21 commented Jun 23, 2019

site/learn/API.md, line 31 at r1 (raw file):

Previously, yehiyam wrote…
api-server

without the api server

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yehiyam yehiyam yehiyam requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maty21 @yehiyam