Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug wrapper algorunner out of memory #128

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

Adir111
Copy link
Contributor

@Adir111 Adir111 commented Aug 8, 2024

Added a method to run a thread that periodically sends a signal to indicate the wrapper is still alive.
Issue: kube-HPC/hkube#1975


This change is Reviewable

@Adir111 Adir111 requested a review from golanha August 8, 2024 12:27
@Adir111 Adir111 self-assigned this Aug 8, 2024
Copy link
Member

@golanha golanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Adir111)


hkube_python_wrapper/wrapper/algorunner.py line 422 at r1 (raw file):

            algorithmData = method(self._input, self._hkubeApi)
            if not (self._stopped):
                self._done = True

Should be set to done before checknig for stopped or not

Code quote:

 self._done = True

Copy link
Contributor Author

@Adir111 Adir111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @golanha)


hkube_python_wrapper/wrapper/algorunner.py line 422 at r1 (raw file):

Previously, golanha (Golan Hallel) wrote…

Should be set to done before checknig for stopped or not

Done.

golanha
golanha previously approved these changes Aug 8, 2024
Copy link
Member

@golanha golanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Adir111)

Copy link
Member

@golanha golanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Adir111)

@Adir111 Adir111 merged commit bbf7243 into master Aug 21, 2024
7 checks passed
hkube-ci pushed a commit that referenced this pull request Aug 21, 2024
…emory

Bug wrapper algorunner out of memory .... bump version [skip ci]
@Adir111 Adir111 deleted the bug_wrapper_algorunner_out_of_memory branch August 21, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants