-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug wrapper algorunner out of memory #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Adir111)
hkube_python_wrapper/wrapper/algorunner.py
line 422 at r1 (raw file):
algorithmData = method(self._input, self._hkubeApi) if not (self._stopped): self._done = True
Should be set to done before checknig for stopped or not
Code quote:
self._done = True
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @golanha)
hkube_python_wrapper/wrapper/algorunner.py
line 422 at r1 (raw file):
Previously, golanha (Golan Hallel) wrote…
Should be set to done before checknig for stopped or not
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Adir111)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Adir111)
…emory Bug wrapper algorunner out of memory .... bump version [skip ci]
Added a method to run a thread that periodically sends a signal to indicate the wrapper is still alive.
Issue: kube-HPC/hkube#1975
This change is