Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rdkafka2 plugin #141

Closed
wants to merge 2 commits into from
Closed

feat: add rdkafka2 plugin #141

wants to merge 2 commits into from

Conversation

onecer
Copy link

@onecer onecer commented Jul 10, 2024

v1.16-4.8/Dockerfile Outdated Show resolved Hide resolved
v1.16/Dockerfile Outdated Show resolved Hide resolved
v1.16-4.8/Dockerfile Outdated Show resolved Hide resolved
@pepov
Copy link
Member

pepov commented Jul 17, 2024

@onecer I've made some updates to be able to go with the least possible change radius.

@pepov
Copy link
Member

pepov commented Jul 17, 2024

Also the way I update the gemfile locks is the following: I run the build locally and copy out the updated lock file from the container to be able to compare changes in an architecture independent way:

docker build . -t fluentd:v1.16
docker run --rm -ti fluentd:v1.16 cat Gemfile.outputs.lock > outputs/Gemfile.lock.internal
# do the diff

@pepov pepov dismissed OverOrion’s stale review July 17, 2024 07:06

the requested changes have been addressed

@pepov
Copy link
Member

pepov commented Jul 17, 2024

fyi we have a few ambigous deps now, could be interesting in case we face any issues

aws-eventstream (1.3.0, 1.2.0)
aws-partitions (1.896.0, 1.851.0)
aws-sdk-core (3.191.3, 3.186.0)
aws-sdk-sqs (1.67.0, 1.64.0)
aws-sigv4 (1.8.0, 1.6.1)
base64 (0.2.0, default: 0.1.1)
bigdecimal (3.1.6, default: 3.1.3, 1.4.4)
bundler (2.5.15, default: 2.4.19)
concurrent-ruby (1.3.3, 1.2.3, 1.1.10)
domain_name (0.6.20231109, 0.5.20190701)
drb (2.2.1, default: 2.1.1)
faraday (2.7.12, 1.10.3)
faraday-excon (2.1.0, 1.1.0)
faraday-net_http (3.0.2, 1.0.1)
fluent-plugin-record-modifier (2.2.0, 2.1.1)
fluent-plugin-sumologic_output (1.9.0, 1.8.0)
fluentd (1.16.3, 1.16.2)
google-protobuf (3.25.3, 3.21.12)
http (5.1.1, 4.4.1)
kubeclient (4.10.1, 4.9.3)
minitest (5.22.2, 5.16.3)
mutex_m (0.2.0, default: 0.1.2)
net-imap (0.4.2, 0.3.4.1)
net-smtp (0.4.0, 0.3.4)
prometheus-client (4.2.2, 4.2.1)
racc (1.8.0, default: 1.6.2)
timeout (0.4.0, default: 0.3.1)
tzinfo-data (1.2024.1, 1.2023.4, 1.2023.3)

@pepov
Copy link
Member

pepov commented Jul 17, 2024

sorry, I realized, this should only be introduced with logging operator version 4.9, which means we only want to add this plugin to v1.16-4.9 which is not yet created.

@pepov
Copy link
Member

pepov commented Jul 17, 2024

I've created a separate PR to implement the changes in a new image version, I would prefer that one to be merged: #142

@pepov pepov self-requested a review July 17, 2024 07:22
@onecer
Copy link
Author

onecer commented Jul 18, 2024

I've created a separate PR to implement the changes in a new image version, I would prefer that one to be merged: #142

Great

@onecer onecer closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUESTION] how to update kafka2 to rdkafka
3 participants