-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rdkafka2 plugin #141
Conversation
Signed-off-by: Onecer <[email protected]>
Signed-off-by: Peter Wilcsinszky <[email protected]>
@onecer I've made some updates to be able to go with the least possible change radius. |
Also the way I update the gemfile locks is the following: I run the build locally and copy out the updated lock file from the container to be able to compare changes in an architecture independent way:
|
the requested changes have been addressed
fyi we have a few ambigous deps now, could be interesting in case we face any issues
|
sorry, I realized, this should only be introduced with logging operator version 4.9, which means we only want to add this plugin to |
I've created a separate PR to implement the changes in a new image version, I would prefer that one to be merged: #142 |
Great |
fix: kube-logging/logging-operator#1373