Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(charts/logging-operator): Improve tailer (image, docs and helm cleanup) #1576

Merged
merged 5 commits into from
Jul 1, 2024
Merged

fix(charts/logging-operator): Improve tailer (image, docs and helm cleanup) #1576

merged 5 commits into from
Jul 1, 2024

Conversation

genofire
Copy link
Collaborator

@genofire genofire commented Nov 6, 2023 •
edited by pepov
Loading

  • Support image
  • Move default values into values.yaml (and add BreakingChange logging.eventTailer.enabled as false by default)
  • Move default values of pvc to values.yaml (and add BreakingChange logging.eventTailer.pvc.enabled as false by default)
  • Move default values of hostTailers as well and also add enabled flag as false by default

@genofire genofire changed the title fix(charts/logging-operator): add image to eventTailer fix(charts/logging-operator): Improve eventTailer Nov 6, 2023
@genofire genofire marked this pull request as ready for review November 6, 2023 11:28
@genofire genofire force-pushed the patch-3 branch 4 times, most recently from 86817e9 to bcd55b6 Compare November 6, 2023 11:59
@genofire genofire changed the title fix(charts/logging-operator): Improve eventTailer fix(charts/logging-operator): Improve eventTailer (image and cleanup) Nov 15, 2023
@genofire genofire changed the title fix(charts/logging-operator): Improve eventTailer (image and cleanup) fix(charts/logging-operator): Improve eventTailer (image and helm cleanup) Nov 15, 2023
pepov
pepov approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@pepov pepov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

charts/logging-operator/values.yaml Outdated Show resolved Hide resolved
@genofire genofire requested a review from pepov November 17, 2023 15:36
@genofire
Copy link
Collaborator Author

genofire commented Nov 17, 2023 •
edited
Loading

i move also all logging parts into a directory:

mkdir loggging; mv logging.yaml logging/; for a in logging_*; do mv $a logging/${a#logging_}; done

@genofire genofire force-pushed the patch-3 branch 3 times, most recently from ad77f6e to 987833f Compare November 17, 2023 15:59
@pepov
Copy link
Member

pepov commented Nov 20, 2023

If we disable eventTailer shouldn't we disable hosttailers as well by default? Could you perhaps add that as well?

@genofire genofire force-pushed the patch-3 branch 4 times, most recently from e34dcfb to edba691 Compare November 27, 2023 16:45
@genofire genofire changed the title fix(charts/logging-operator): Improve eventTailer (image and helm cleanup) fix(charts/logging-operator): Improve tailer (image, docs and helm cleanup) Nov 27, 2023
@genofire
Copy link
Collaborator Author

okay, ready to review again

@pepov
Copy link
Member

pepov commented Nov 27, 2023

Looks good to me, have you been able to test it?

@genofire
Copy link
Collaborator Author

not yet - and i am not sure if i could spend time this year. For us it is an requirement for an update, so i just make it as prepeare it.

@genofire genofire force-pushed the patch-3 branch 2 times, most recently from 5661bd5 to 9ad2694 Compare November 28, 2023 19:52
@genofire
Copy link
Collaborator Author

any news?

@pepov pepov added the enhancement New feature or request label Jan 17, 2024
@pbdger pbdger mentioned this pull request Jan 30, 2024
Closed
OverOrion
OverOrion previously requested changes Jan 31, 2024
View reviewed changes
charts/logging-operator/values.yaml Outdated Show resolved Hide resolved
@stale Stale
Copy link

stale bot commented Mar 31, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the wontfix This will not be worked on label Mar 31, 2024
@stale stale bot closed this Apr 7, 2024
@genofire
Copy link
Collaborator Author

genofire commented Jun 14, 2024 •
edited
Loading

Please reopen it -> otherwise i could not work on it.

Sorry, i miss that PR.

@OverOrion OverOrion reopened this Jun 17, 2024
@stale stale bot removed the wontfix This will not be worked on label Jun 17, 2024
@genofire
Copy link
Collaborator Author

done and hopefull rebased correct after merge of #1674

@OverOrion OverOrion self-requested a review June 19, 2024 11:01
@pepov
Copy link
Member

pepov commented Jun 30, 2024

I've tested, rebased and fixed indentation issues, good to go from my side. @OverOrion please take a look!

@pepov pepov added breaking-change enhancement New feature or request and removed enhancement New feature or request labels Jun 30, 2024
@pepov pepov dismissed OverOrion’s stale review July 1, 2024 10:05

The change request has been addressed

@pepov pepov merged commit f93273c into kube-logging:master Jul 1, 2024
17 checks passed
@genofire
Copy link
Collaborator Author

genofire commented Jul 3, 2024

oh thank you for doing my work duck

@genofire genofire deleted the patch-3 branch July 3, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepov pepov pepov approved these changes

@kristofgyuracz kristofgyuracz kristofgyuracz approved these changes

@OverOrion OverOrion Awaiting requested review from OverOrion

Assignees
No one assigned
Labels
breaking-change enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@genofire @pepov @kristofgyuracz @OverOrion