Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add json format for fluentd output #1657

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

pbdger
Copy link

@pbdger pbdger commented Jan 30, 2024

This change adds a feature to set FluentD output to json format.

spec:
  fluentd:
    logFormat: json

The default is still text. Adding the new value logFormat: json will modify the fluendtd-Container file /fluentd/etc/input.conf.

@pepov
Copy link
Member

pepov commented Jan 30, 2024

@pepov pepov self-requested a review February 4, 2024 08:15
@pepov
Copy link
Member

pepov commented Feb 26, 2024

@pbdger do you plan to fix the CI issues? (You should run a make check-diff locally and push the changes, as well as add signoff to all your commits.)

Copy link

stale bot commented Apr 26, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the wontfix This will not be worked on label Apr 26, 2024
@pepov pepov force-pushed the feat/fluentd-support-json-output branch from f8fdc41 to 01186e5 Compare April 29, 2024 13:16
@stale stale bot removed the wontfix This will not be worked on label Apr 29, 2024
@pepov
Copy link
Member

pepov commented Apr 29, 2024

@pbdger updated the PR and squashed commits into one to pass the checks

Co-authored-by: Peter Wilcsinszky <[email protected]>
Signed-off-by: pbdger <[email protected]>
Signed-off-by: Peter Wilcsinszky <[email protected]>
@pepov pepov force-pushed the feat/fluentd-support-json-output branch from 01186e5 to 8bfa19f Compare April 29, 2024 13:19
@pepov pepov merged commit 25442d6 into kube-logging:master Apr 29, 2024
17 checks passed
@pepov pepov added the enhancement New feature or request label May 28, 2024
@pbdger pbdger deleted the feat/fluentd-support-json-output branch June 14, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants