Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigCheck for aggregators #1747

Merged
merged 3 commits into from
May 28, 2024
Merged

ConfigCheck for aggregators #1747

merged 3 commits into from
May 28, 2024

Conversation

pepov
Copy link
Member

@pepov pepov commented May 27, 2024 •
edited
Loading

@pepov pepov force-pushed the configcheck-aggregatorconfig branch from a7a1b66 to 7b72371 Compare May 27, 2024 14:25
@pepov pepov changed the title configcheck aggregatorconfig ConfigCheck for aggregators May 27, 2024
OverOrion
OverOrion approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the comments need . so the generated docs look nice.

pkg/sdk/logging/api/v1beta1/fluentd_types.go Show resolved Hide resolved
pkg/sdk/logging/api/v1beta1/fluentd_types.go Show resolved Hide resolved
pkg/sdk/logging/api/v1beta1/logging_types.go Outdated Show resolved Hide resolved
pkg/sdk/logging/api/v1beta1/syslogng_types.go Outdated Show resolved Hide resolved
kristofgyuracz
kristofgyuracz approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@kristofgyuracz kristofgyuracz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the suggested changes.

@pepov @OverOrion
Apply suggestions from code review
f0e4f2b 
Co-authored-by: Szilard Parrag <[email protected]>
Signed-off-by: Peter Wilcsinszky <[email protected]>
@pepov pepov force-pushed the configcheck-aggregatorconfig branch from 6351668 to f0e4f2b Compare May 28, 2024 07:21
@pepov pepov merged commit 8081f4b into master May 28, 2024
19 checks passed
@pepov pepov deleted the configcheck-aggregatorconfig branch May 28, 2024 07:35
@pepov pepov added the enhancement New feature or request label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristofgyuracz kristofgyuracz kristofgyuracz approved these changes

@OverOrion OverOrion OverOrion approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pepov @kristofgyuracz @OverOrion