Gelf output plugin: improved docs and add missing flags #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmichalkiewicz
force-pushed
the
gelf_output_plugin
branch
from
9dad4ba
to
f97d619
Compare
|
There should be information about which Fluentd image supports the max_bytes flag, but I don't know it at the moment. |
|
@bmichalkiewicz most probably it will be 4.10 |
|
Thanks for the information :) |
bmichalkiewicz
force-pushed
the
gelf_output_plugin
branch
2 times, most recently
from
ade1ef6
to
edf4919
Compare
|
@bmichalkiewicz would you mind updating the image to 4.10 once https://github.com/kube-logging/fluentd-images/actions/runs/11032457110 has been built? this is where the image is configured: Related PR: |
Signed-off-by: Bartosz <[email protected]>
Signed-off-by: Bartosz <[email protected]>
Signed-off-by: Bartosz <[email protected]>
Signed-off-by: Bartosz <[email protected]>
pepov
force-pushed
the
gelf_output_plugin
branch
from
edf4919
to
cd12738
Compare
|
the image has already updated in main, started a rebase |
pepov
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request corrects documentation and adds the missing max_bytes flag (introduced in version 1.3.4 of fluent-plugin-gelf-best).
Additionally, the term "GELF" has been changed to "Gelf" in the code for clarity, as there's no reason to capitalize it.
we need to update the gem to version 1.3.4 as it fixes: Graylog2/graylog2-server#873