feat: add possibility to inject auth info from secrets #85
+593
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristofgyuracz
force-pushed
the
secret-auth
branch
2 times, most recently
from
36cf40e
to
534ece7
Compare
Signed-off-by: Kristof Gyuracz <[email protected]>
kristofgyuracz
force-pushed
the
secret-auth
branch
from
534ece7
to
4b9b139
Compare
OverOrion
reviewed
Oct 4, 2024
Comment on lines
+113
to
+120
| if queriedOutput.Spec.Authentication != nil { | ||
| if queriedOutput.Spec.Authentication.BasicAuth != nil && queriedOutput.Spec.Authentication.BasicAuth.SecretRef != nil { | ||
| queriedSecret := &corev1.Secret{} | ||
| if err = r.Client.Get(ctx, types.NamespacedName{Namespace: queriedOutput.Spec.Authentication.BasicAuth.SecretRef.Namespace, Name: queriedOutput.Spec.Authentication.BasicAuth.SecretRef.Name}, queriedSecret); err != nil { | ||
| logger.Error(errors.WithStack(err), "failed getting secrets for output", "output", queriedOutput.NamespacedName().String()) | ||
| } | ||
| outputWithSecretData.Secret = *queriedSecret | ||
| } |
There was a problem hiding this comment.
Could you please extract these into a GetSecret() / PopulateSecret() method for BasicAuthConfig / BearerAuthConfig?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.