Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bypass nightly ICE in docs build #1155

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Bypass nightly ICE in docs build #1155

merged 1 commit into from
Mar 1, 2023

Conversation

clux
Copy link
Member

@clux clux commented Mar 1, 2023

Via #1150
and upstream rust-lang/rust#108501

@clux clux added the changelog-fix changelog fix category for prs label Mar 1, 2023
@clux clux added this to the 0.80.0 milestone Mar 1, 2023
@clux clux linked an issue Mar 1, 2023 that may be closed by this pull request
Docs.rs build failed for kube 0.79 #1150
Closed
@clux
Copy link
Member Author

clux commented Mar 1, 2023 •
edited
Loading

Clippy issues are unrelated and are bypassed in #1152 in particular; 1ecb6ec

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #1155 (40eff5a) into main (825aba8) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
+ Coverage   72.26%   72.28%   +0.01%     
==========================================
  Files          67       67              
  Lines        5106     5106              
==========================================
+ Hits         3690     3691       +1     
+ Misses       1416     1415       -1
Impacted Files Coverage Δ
kube/src/lib.rs 89.04% <ø> (ø)
kube-runtime/src/wait.rs 77.35% <0.00%> (+1.88%) ⬆️

@clux clux merged commit b156131 into main Mar 1, 2023
@clux clux deleted the fix-doc-ice branch March 1, 2023 23:27
@clux
Copy link
Member Author

clux commented Mar 2, 2023 •
edited
Loading

Created 0.80 and prepared release notes for it in https://github.com/kube-rs/kube/releases/

We are number 377 in the queue for the docs.rs build though, so probably not worth waiting for it.. peoples' dependabot/rennovate prs tend to hit before docs.rs completes.

@clux
Copy link
Member Author

clux commented Mar 3, 2023

It worked 😌
https://docs.rs/crate/kube/0.80.0/builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazk kazk kazk approved these changes

Assignees
No one assigned
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Milestone
0.80.0
Development

Successfully merging this pull request may close these issues.

Docs.rs build failed for kube 0.79
2 participants
@clux @kazk