Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename new watcher Event names and remove one that cannot happen #1499

Merged
merged 7 commits into from
May 29, 2024
Merged

Rename new watcher Event names and remove one that cannot happen #1499

merged 7 commits into from
May 29, 2024

Commits on May 23, 2024

  1. Rename watcher Event names and remove one that cannot happen 

    1. Event::Init now marks start, it is followed by one/more of:
2. Event::InitApply or EventInitPage
3. Event::Ready marks init complete

removed Event::RestartDelete because by docs it cannot happen:
https://kubernetes.io/docs/reference/using-api/api-concepts/#streaming-lists

have inserted a big error in case they break their own docs for this alpha feature.

Signed-off-by: clux <[email protected]>
    @clux
    clux committed May 23, 2024
    Configuration menu
    Copy the full SHA
    1786d17 View commit details
    Browse the repository at this point in the history

  2. fmt 

    Signed-off-by: clux <[email protected]>
    @clux
    clux committed May 23, 2024
    Configuration menu
    Copy the full SHA
    59efd8d View commit details
    Browse the repository at this point in the history

  3. reomve references to deleted event + fix reducer oversight 

    InitApply should be propagated here, pages are.

Signed-off-by: clux <[email protected]>
    @clux
    clux committed May 23, 2024
    Configuration menu
    Copy the full SHA
    2f24234 View commit details
    Browse the repository at this point in the history

  4. avoid unnecessary collect 

    Signed-off-by: clux <[email protected]>
    @clux
    clux committed May 23, 2024
    Configuration menu
    Copy the full SHA
    4f69a37 View commit details
    Browse the repository at this point in the history

  5. rename Event::Ready -> Event::InitDone for consistency 

    Signed-off-by: clux <[email protected]>
    @clux
    clux committed May 23, 2024
    Configuration menu
    Copy the full SHA
    3d48ad2 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. Merge branch 'main' into watcher-event-rename-fixup

    @clux
    clux authored May 26, 2024
    Configuration menu
    Copy the full SHA
    b34b327 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Merge branch 'main' into watcher-event-rename-fixup

    @clux
    clux authored May 27, 2024
    Configuration menu
    Copy the full SHA
    f551056 View commit details
    Browse the repository at this point in the history