add api config endpoints to nginx config #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik-kc
approved these changes
Jul 8, 2024
|
/cherry-pick v2.3 |
1 similar comment
|
/cherry-pick v2.3 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
add api config endpoints to nginx config
nickcurie
added a commit
that referenced
this pull request
Jul 9, 2024
add api config endpoints to nginx config (cherry-pick #3532)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Nginx config for get and set api config endpoints in aggregator
Does this PR rely on any other PRs?
https://github.com/kubecost/kubecost-cost-model/pull/2575
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Fix a bug that broke custom labels
Links to Issues or tickets this PR addresses or fixes
https://kubecost.atlassian.net/browse/ENG-2392
What risks are associated with merging this PR? What is required to fully test this PR?
No risks, PR can be tested by setting custom labels in the settings UI and observing that custom labels have carried over to the allocations page
How was this PR tested?
Put a custom image of this PR on qa-eks3 controller namespace, changed custom labels in settings UI, observed new custom label was working properly in the allocations UI. Also checked the apiconfig.json file in the aggregator pod, which contained all the expected custom label configurations.
Have you made an update to documentation? If so, please provide the corresponding PR.
No docs needed