Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

[feature] Suppory unit test by providing handlers for updateStatus and DeleteJob #106

Open
gaocegege opened this issue Jan 14, 2021 · 2 comments
Open

[feature] Suppory unit test by providing handlers for updateStatus and DeleteJob #106

gaocegege opened this issue Jan 14, 2021 · 2 comments
Assignees
@ChanYiLin

Comments

@gaocegege
Copy link
Member 

	// TODO(ChanYiLin): these are originally for testing, but with using common library,
	// we can not replcae the function. Also need to update or remove some tests

	// tc.updateStatusHandler = tc.UpdateJobStatusInApiServer
	// set delete handler.
	// tc.deleteTFJobHandler = tc.DeleteJob

It will be better to have such handlers to replace them when running test cases.

/cc @ChanYiLin
@ChanYiLin
Copy link
Member

Thanks for the reminder, I'll take this issue.

@ChanYiLin
Copy link
Member

/assign @ChanYiLin

georgkaleido pushed a commit to georgkaleido/common that referenced this issue Jun 9, 2022
@lingcong-k @otherguy
@github-actions @Jerome-Kaleido
Add semitransparency model into removebg (kubeflow#106)
f373b1c 
* 1.initial submit of adding semitransparency into removebg pipeline

* merged new semitransparency model into removebg, local tested thro rabbitmq, all test passed

* 1.remove testing the new model in test_carinterior_semitransparency 2.modified test_car_semitransparency for api

* 1.modified some changes that i made when testing locally but forgot to change back. mainly in removebg.demo and remove.py

* changed removebg resize related code, before when testing locally, it has issue with DA lib, so need to squeeze it before resizing. now testing tro building the whole pipeline pass

* 1.modified server code and related test files on adding a new flag for the new semitransparency model. 2. updated semitransparency-core lib version

* remove the squeeze and unsqueeze code which is needed to test locally. change the version requirement for semitransparency-core

* putting model into eval and half when initializing instead of in semitransparency func

* upgraded semitransparency-core lib to remove google cloud related and updated the requirement

* pillow requirement removed from requirementdeploy

* update semitransparencycore lib version to 0.9.1

* update semitransparency-core-lib to the newest version 0.9.3

Co-authored-by: Alexander Graf <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: jerome <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ChanYiLin ChanYiLin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaocegege @ChanYiLin