Move Pods/Services control interface to separate folder #72
Conversation
Even we replace all kubernetes dependencies in go.mod, we want to use lowest version to avoid potential dependency issues. See kubeflow#70 for more details. Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
|
This change is |
|
/assign @terrytangyuan |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Jeffwan We also need to update the import statement in xgboost-operator |
|
@terrytangyuan What's the statement? Do you need me to help update common there? |
|
@Jeffwan Never mind. It looks like there is no public interface change yet so I am only updating the version of common in kubeflow/xgboost-operator#47. |
Leave you comment on the PR. |
* Update config.yml
Currently, pods/services implementation mixed with jobController together under
commonfolder, this is a little messy.The reason we want to have separate folder (package name) for it are
PodControlInterface is folked from controller_util.go and we also implement similar codes for service. They are logically separate. For long term, once Adding expectations and controller ref manager to client-go kubernetes/client-go#332 is merged, we could remove the folder entirely.
Since
PodControlInterfaceandServiceControlInterfaceare internal code base for common project, there's no need for users to import them at all.Trying to make some changes inside
controlto solve Delete direct dependency of kubernetes #48. It would be better to file this PR first and make changes against new folder, that would be easier for review. Otherwise, it's a new file.