Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Add PodControlInterface and PodControllerRefManager #73

Merged
merged 7 commits into from
Apr 20, 2020
Merged

Add PodControlInterface and PodControllerRefManager #73

merged 7 commits into from
Apr 20, 2020

Commits on Apr 15, 2020

  1. Add PodControlInterface and FakePodControl

    @Jeffwan
    Jeffwan committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    7574f6c View commit details
    Browse the repository at this point in the history

  2. Add comments for service event reasons

    @Jeffwan
    Jeffwan committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    088f125 View commit details
    Browse the repository at this point in the history

  3. Skip deleting pods/services already in termination 

    Kubernetes pkg/controller/controller_utils.go doesn’t have this logic. This is from kubeflow/training-operator/pull/998. I think it’s safe to keep the logic here.
    @Jeffwan
    Jeffwan committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    e518b2e View commit details
    Browse the repository at this point in the history

  4. Remove Kubernetes controller dependency 

    Use `KeyFunc` instead of k8s.io/kubernetes/pkg/controller.KeyFunc
    @Jeffwan
    Jeffwan committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    3966c84 View commit details
    Browse the repository at this point in the history

  5. Add Base and PodControllerRefManager 

    Current implementation use PodControllerRefManager from `k8s.io/kubernetes/pkg/controller` and self-implemented `ServiceControllerRefManager` which brings some problems.

1. Pod impl may change along with k8s upgrade, service impl doesn’t
2. It’s not helping us remove Kubernetes direct dependency.
3. It’s not that straighforward for maintainers and contributors.

This change make sure we folk everything we need and remove ref_manager dependency.
    @Jeffwan
    Jeffwan committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    497f488 View commit details
    Browse the repository at this point in the history

  6. Rename service_ref_manager to controller_ref_manager 

    Since this file contains both BaseControllerRefManager, PodControllerRefManager and ServiceControllerRefManager. It makes sense to rename it to controller_ref_manager.go
    @Jeffwan
    Jeffwan committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    bbcb9be View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2020

  1. Address code review feedbacks

    @Jeffwan
    Jeffwan committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    96b4b11 View commit details
    Browse the repository at this point in the history