Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add js-ts as an approver #899

Merged
merged 1 commit into from
Nov 14, 2021
Merged

Add js-ts as an approver #899

merged 1 commit into from
Nov 14, 2021

Conversation

js-ts
Copy link
Member

@js-ts js-ts commented Nov 12, 2021

Thanks @jinchihe for the opportunity

@js-ts
Copy link
Member Author

js-ts commented Nov 12, 2021

/assign @jinchihe

@jinchihe
Copy link
Member

Welcome! Seems you are not member of Kubeflow org? would you please add kubeflow org firstly? Thanks. @js-ts

@js-ts
Copy link
Member Author

js-ts commented Nov 13, 2021

@jinchihe my PR to become a Kubeflow member got approved

@google-oss-prow
Copy link

@js-ts: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jinchihe
Copy link
Member

/verify-owners

@jinchihe
Copy link
Member

/lgtm
/approve

Thanks @js-ts welcome contribution as maintainer!

@google-oss-prow google-oss-prow bot added the lgtm label Nov 14, 2021
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinchihe, js-ts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7941816 into kubeflow:master Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants