Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TobiasGoerke to org #593

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Add TobiasGoerke to org #593

merged 1 commit into from
Mar 7, 2023

Conversation

TobiasGoerke
Copy link
Contributor

@TobiasGoerke TobiasGoerke commented Feb 20, 2023

I'm looking forward to becoming a member!

I'm asking @kimwnasptd and @juliusvonkohout to sponsor my request.

Selection of contributions:

Edit: Test Output

❯ python3 -m pytest test_org_yaml.py
================================ test session starts =================================
platform linux -- Python 3.10.6, pytest-7.2.1, pluggy-1.0.0
rootdir: /tmp/internal-acls/github-orgs
collected 1 item

test_org_yaml.py .                                                             [100%]

================================= 1 passed in 0.26s ==================================

Adding TobiasGoerke to member list
@google-oss-prow
Copy link

Hi @TobiasGoerke. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TobiasGoerke
Copy link
Contributor Author

@TobiasGoerke what about the acl repository?

What do you mean? Are there any more places I should add my username to?

@juliusvonkohout
Copy link
Member

here are some hints

#509
#584
kubeflow/manifests#2337

@juliusvonkohout
Copy link
Member

ah my mistake, this is already the acl repository.

@kimwnasptd
Copy link
Member

Thanks you for the great contributions @TobiasGoerke!

/lgtm
/cc @zijianjoy

@zijianjoy
Copy link
Contributor

/lgtm
/approve

@TobiasGoerke Welcome to the community!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TobiasGoerke, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1447e95 into kubeflow:master Mar 7, 2023
@TobiasGoerke
Copy link
Contributor Author

/lgtm /approve

@TobiasGoerke Welcome to the community!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants