Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rawc0der as member #641

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

rawc0der
Copy link
Member

Links to PRs:

Issues, misc:

Pytest output:

$ pytest test_org_yaml.py                                                              

================================================= test session starts =================================================
platform darwin -- Python 3.9.18, pytest-6.2.3, py-1.10.0, pluggy-0.13.1
rootdir: /Users/alinspinu/Documents/RawDataLabs/GitHub/internal-acls/github-orgs
collected 1 item                                                                                                      

test_org_yaml.py .                                                                                              [100%]

================================================== 1 passed in 0.21s ==================================================

Copy link

Hi @rawc0der. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rawc0der
Copy link
Member Author

Hi @juliusvonkohout and @kimwnasptd, would you be able to become my sponsors?

Thanks!

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Jan 12, 2024

In general yes, but I think there should be at least one merged PR. Currently there are only drafts or open ones as far as I can see. I just reran the tests for the pipelines PR, but I think you need to follow up in the KFP meetings to get it merged. You can also see that we only have 8 open PRs now in kubeflow/manifests (before 52). The network policies are not forgotten and I have put them on the manifests WG 1.9 roadmap.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Jan 12, 2024

And it's definitely possible, I just got @kromanow94 added in

89d844f

@juliusvonkohout
Copy link
Member

After addressing the issues above you can ping @zijianjoy here and on slack (James Liu) to merge.

@rimolive
Copy link
Member

/lgtm

@rimolive
Copy link
Member

/ok-to-test

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawc0der, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e14131a into kubeflow:master Apr 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants