-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rawc0der as member #641
Conversation
Hi @rawc0der. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @juliusvonkohout and @kimwnasptd, would you be able to become my sponsors? Thanks! |
In general yes, but I think there should be at least one merged PR. Currently there are only drafts or open ones as far as I can see. I just reran the tests for the pipelines PR, but I think you need to follow up in the KFP meetings to get it merged. You can also see that we only have 8 open PRs now in kubeflow/manifests (before 52). The network policies are not forgotten and I have put them on the manifests WG 1.9 roadmap. |
And it's definitely possible, I just got @kromanow94 added in |
After addressing the issues above you can ping @zijianjoy here and on slack (James Liu) to merge. |
/lgtm |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rawc0der, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Links to PRs:
Issues, misc:
Pytest output: