kwa(build): Introduce COMMIT file for building KWA (#2014)

Introduce COMMIT file that contains the commit where Katib needs to checkout inside Kubeflow's common code in order to be built. This file was integrated in the following places as well, thus a developer may only update one file each time we need to checkout to a newer commit. - Dockerfile - GH actions - README.md Signed-off-by: Orfeas Kourkakis <[email protected]> Signed-off-by: Orfeas Kourkakis <[email protected]>
kubeflow · Nov 16, 2022 · 24c970b · 24c970b
1 parent c50e1d3
commit 24c970b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/.github/workflows/test-node.yaml b/.github/workflows/test-node.yaml
@@ -38,9 +38,10 @@ jobs:
 
       - name: Fetch Kubeflow and install common code dependencies
         run: |
+          COMMIT=$(cat pkg/new-ui/v1beta1/frontend/COMMIT)
           cd /tmp && git clone https://github.com/kubeflow/kubeflow.git
           cd kubeflow
-          git checkout c4ca7a9
+          git checkout $COMMIT
           cd components/crud-web-apps/common/frontend/kubeflow-common-lib
           npm i
           npm run build

diff --git a/cmd/new-ui/v1beta1/Dockerfile b/cmd/new-ui/v1beta1/Dockerfile
@@ -4,9 +4,11 @@ FROM ubuntu AS fetch-kubeflow-kubeflow
 RUN apt-get update && apt-get install git -y
 
 WORKDIR /kf
+COPY ./pkg/new-ui/v1beta1/frontend/COMMIT ./
 RUN git clone https://github.com/kubeflow/kubeflow.git && \
+    COMMIT=$(cat ./COMMIT) && \
     cd kubeflow && \
-    git checkout c4ca7a9
+    git checkout $COMMIT
 
 # --- Build the frontend kubeflow library ---
 FROM node:12 AS frontend-kubeflow-lib

diff --git a/pkg/new-ui/v1beta1/README.md b/pkg/new-ui/v1beta1/README.md
@@ -40,9 +40,10 @@ In order to build the UI locally, and expose it with a webpack dev server you wi
 You can build the common library with:
 
 ```bash
-cd /tmp && git clone https://github.com/kubeflow/kubeflow.git \
+COMMIT=$(cat ./frontend/COMMIT) \
+  && cd /tmp && git clone https://github.com/kubeflow/kubeflow.git \
   && cd kubeflow \
-  && git checkout c4ca7a9 \
+  && git checkout $COMMIT \
   && cd components/crud-web-apps/common/frontend/kubeflow-common-lib
 
 # build the common library module

diff --git a/pkg/new-ui/v1beta1/frontend/COMMIT b/pkg/new-ui/v1beta1/frontend/COMMIT
@@ -0,0 +1 @@
+c4ca7a9